Skip to content

feat: Modify the next frame delay method by changing setTimeout to re… #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Planck-Ho wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: Modify the next frame delay method by changing setTimeout to re… #857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/suite-base/src/players/IterablePlayer/IterablePlayer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ const MEMORY_INFO_BUFFERED_MSGS = "Buffered messages";

const EMPTY_ARRAY = Object.freeze([]);

const FRAME_TIME = 1000 / 60; // aim for 60fps

export type IterablePlayerOptions = {
metricsCollector?: PlayerMetricsCollectorInterface;

Expand Down Expand Up @@ -1124,6 +1126,7 @@ export class IterablePlayer implements Player {
const allTopics = this.#allTopics;

try {
let start = performance.now();
while (this.#isPlaying && !this.#hasError && !this.#nextState) {
if (compare(this.#currentTime, this.#end) >= 0) {
// Playback has ended. Reset internal trackers for maintaining the playback speed.
Expand All @@ -1134,8 +1137,6 @@ export class IterablePlayer implements Player {
return;
}

const start = Date.now();

await this.#tick();
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition, @typescript-eslint/strict-boolean-expressions
if (this.#nextState) {
Expand Down Expand Up @@ -1164,12 +1165,14 @@ export class IterablePlayer implements Player {
return;
}

const time = Date.now() - start;
// make sure we've slept at least 16 millis or so (aprox 1 frame)
// to give the UI some time to breathe and not burn in a tight loop
if (time < 16) {
await delay(16 - time);
}
let time: number;
do {
await new Promise(requestAnimationFrame);
time = performance.now();
} while (time - start < FRAME_TIME);
start = time;
}
} catch (e: unknown) {
const err = e as Error;
Expand Down
Loading