feat(@clayui/css): LPD-51801 Adds .blockquote variant for .form-text #6059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethib137
requested changes
May 15, 2025
There was a problem hiding this comment.
Thanks @pat270 ... In looking at the gif, it appears that spacing between the input and the text does not match what is in the figma. Could you update that? Also make sure the spacing is correct when there is an input description or an error as well.
Additionally, this should be added to the story book and to the forms documentation page.
Thanks.
|
@ethib137 this should be good to go. We have no way of inserting an error message before the default text. We will need to add that feature if needed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-51801
Not sure if I implemented this correctly, but it looks like they just want a style change?