Support for Http patch method in RestHelper - #1874
Conversation
farmdawgnation
left a comment
There was a problem hiding this comment.
Can you please add a test to RestHelperSpec that tests this? There should already be a test in there for OPTIONS so it should be pretty straightforward to add one for PATCH.
|
@farmdawgnation more tests coming soon |
farmdawgnation
left a comment
There was a problem hiding this comment.
This LGTM.
If you have more tests you want to add that's fine, but I think this is sufficient for now. We need to improve testing writ large, but this brings the testing up to the level that the rest of it is currently at.
Barring any concerns being surfaced in the next day or so, I'll probably go ahead and merge this.
|
I would like to write more test but I haven't found the time yet. |
Of course. |
Mailing List thread:
https://groups.google.com/forum/#!topic/liftweb/4ByUPd1TMkc
Issue #1873