Skip to content

Conversation

fmorency
Copy link
Contributor

@fmorency fmorency commented Apr 10, 2025

This pull request includes several updates to dependencies, improvements to the test suite, and changes to the configuration files. The most important changes include transitioning to @tanstack/react-query, updating the web3auth integration, and adding support for the Ghostcloud REST endpoint.

Dependency Updates:

  • Updated react-query to @tanstack/react-query across the codebase, including test files and main application files. [1] [2] [3] [4] [5]
  • Updated various dependencies in package.json including @web3auth packages, react, next, and @cosmjs packages. [1] [2]

Configuration Changes:

  • Added NEXT_PUBLIC_GHOSTCLOUD_REST_TARGET to the .env.local file.
  • Added GHOSTCLOUD_REST_TARGET to config/ghostcloud-chain.ts and updated its usage in the codebase.

Web3Auth Integration:

  • Updated imports and initialization for web3auth to use the new @web3auth/auth-adapter instead of openlogin-adapter. [1] [2] [3] [4]

Ghostcloud Integration:

  • Added useLcdQueryClient hook for interacting with the Ghostcloud REST endpoint.
  • Updated useFetchMetas, useFetchBalance, and other related hooks to use the LCD client instead of the RPC client. [1] [2] [3] [4]

Miscellaneous:

  • Updated the dev script in package.json to use next dev --turbopack.
  • Added error handling for queries using QueryCache in pages/_app.tsx.

@fmorency fmorency requested a review from Copilot April 10, 2025 17:36
@fmorency fmorency self-assigned this Apr 10, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

config/web3-auth.ts:19

  • The label still uses 'openlogin' even though the adapter key has been updated to AUTH; consider updating the label to reflect the new adapter for clarity.
label: "openlogin",

@fmorency fmorency marked this pull request as draft April 10, 2025 19:00
@fmorency fmorency requested a review from Copilot April 10, 2025 19:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 16 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • .env.local: Language not supported
  • package.json: Language not supported
Comments suppressed due to low confidence (3)

lib/ghostcloud.ts:146

  • The invalidation of queries using a static key array (e.g. ["metas"]) may not fully invalidate queries that are registered with composite keys (e.g. ["metas", page]). Consider aligning the invalidation keys to match the dynamic query keys to ensure cache consistency.
queryClient.invalidateQueries({ queryKey: ["metas"] })

config/web3-auth.ts:18

  • [nitpick] The adapter label is still set as 'openlogin' while using the AUTH adapter. Consider updating the label to better reflect the new adapter for clarity.
[WALLET_ADAPTERS.AUTH]: { label: "openlogin",

lib/ghostcloud.ts:320

  • [nitpick] The use of 'placeholderData' with the imported 'keepPreviousData' may not behave as intended compared to the previous 'keepPreviousData: true' option. Verify that this change preserves previous data as expected or adjust the implementation accordingly.
placeholderData: keepPreviousData,

@fmorency fmorency marked this pull request as ready for review April 10, 2025 19:31
@fmorency fmorency requested review from jgryffindor and nblenke April 10, 2025 19:33
@fmorency fmorency mentioned this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant