Skip to content

Conversation

@fmorency
Copy link
Contributor

This pull request includes several changes to the configuration, build process, and dependencies for the ghostcloud project. The most important changes are grouped into configuration updates, build process enhancements, and dependency updates.

Configuration Updates:

Build Process Enhancements:

  • Makefile: Introduced new build tags, flags, and installation commands. Added support for building with ledger and cleveldb, and included protobuf generation steps.

Dependency Updates:

  • go.mod: Updated the Go version to 1.23.8 and upgraded several dependencies, including cosmos-sdk, cometbft, grpc, and others. [1] [2] [3] [4] [5]

Minor Code Changes:

  • app/app.go: Added a call to WithQueryRouter for ICAHostKeeper to set up the gRPC query router.

Removal of Redundant Targets:

  • Makefile: Removed the nancy target, which was used for dependency vulnerability scanning.

@fmorency fmorency requested a review from Copilot April 10, 2025 14:13
@fmorency fmorency self-assigned this Apr 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • Makefile: Language not supported
  • go.mod: Language not supported
Comments suppressed due to low confidence (1)

app/app.go:443

  • Ensure that GRPCQueryRouter is fully initialized prior to being passed to ICAHostKeeper to avoid potential issues during query handling.
app.ICAHostKeeper.WithQueryRouter(app.GRPCQueryRouter())

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.83%. Comparing base (ab649b8) to head (246e2e6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   63.83%   63.83%           
=======================================
  Files          28       28           
  Lines        1117     1117           
=======================================
  Hits          713      713           
  Misses        359      359           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fmorency fmorency requested a review from jgryffindor April 10, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant