Skip to content

Conversation

@fmorency
Copy link
Contributor

This pull request introduces several significant improvements to the build system, code coverage, simulation tooling, and generated gRPC code for the project. The most notable changes include a major overhaul of the Makefile to enhance build, test, and simulation workflows, updates to the Go version and CI configuration, and the addition of new gRPC service files. Below are the most important changes grouped by theme:

Build System and CI Enhancements

  • Overhauled the Makefile to add advanced build flags, dynamic versioning, improved build tag handling, and new targets for installation, protobuf generation, and simulation. The coverage workflow now merges simulation and unit test coverage for more accurate reporting. Obsolete or redundant targets (like nancy) were removed, and the golangci-lint version was updated. [1] [2] [3] [4]
  • Updated the Go version in .circleci/config.yml from 1.22 to 1.23.12 and commented out the security job in both the jobs and workflows sections, likely to address compatibility or performance issues. [1] [2] [3]

Test Coverage and Simulation

  • Improved coverage handling by instrumenting simulation tests, merging coverage data from simulation and unit/e2e tests, and generating both text and HTML reports. Added new .coverageignore patterns for coverage filtering. [1] [2]
  • Added comprehensive simulation targets to the Makefile for running full app simulations, import/export, after-import, and determinism tests, with options for random seeds and parameterization.

Generated gRPC Code

  • Added new generated gRPC client and server code for the Query and Msg services in api/liftedinit/ghostcloud/v1/query_grpc.pb.go and api/liftedinit/ghostcloud/v1/tx_grpc.pb.go, respectively. These provide type-safe interfaces for interacting with the Ghostcloud module over gRPC. [1] [2]

These changes collectively modernize the build and test infrastructure, improve developer productivity, and lay the groundwork for more robust service integrations.

Depends on #68

@fmorency fmorency requested a review from Copilot August 13, 2025 15:01
@fmorency fmorency self-assigned this Aug 13, 2025

This comment was marked as outdated.

@fmorency fmorency requested a review from Copilot August 13, 2025 15:55

This comment was marked as outdated.

@fmorency
Copy link
Contributor Author

@fmorency fmorency requested a review from Copilot August 14, 2025 13:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements significant refactoring to migrate the ghostcloud module from the legacy Cosmos SDK parameter store to the modern collections framework, while also updating generated protobuf files to use a new namespace structure. The changes improve code maintainability, type safety, and align with current Cosmos SDK best practices.

  • Migrates parameter storage from x/params to collections framework for better type safety and performance
  • Updates protobuf namespace from ghostcloud.ghostcloud to liftedinit.ghostcloud.v1 for better organization
  • Refactors simulation code to use modern patterns and removes deprecated helper functions

Reviewed Changes

Copilot reviewed 82 out of 86 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
x/ghostcloud/types/tx.pb.go Updates protobuf namespace and file descriptor references
x/ghostcloud/types/query.pb.go Updates gRPC service names and protobuf namespace
x/ghostcloud/types/params.pb.go Updates protobuf namespace and file descriptor
x/ghostcloud/keeper/keeper.go Migrates from legacy parameter store to collections framework
x/ghostcloud/keeper/params.go Replaces parameter store methods with collections-based implementations
x/ghostcloud/simulation/operations.go Implements modern simulation patterns replacing deprecated approaches
x/ghostcloud/module.go Updates module to support collections and removes deprecated simulation code

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@fmorency fmorency marked this pull request as ready for review August 14, 2025 13:19
@fmorency fmorency mentioned this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant