-
Notifications
You must be signed in to change notification settings - Fork 3
feat: POA/Manifest Ghostcloud #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Migration guide in https://gist.github.com/fmorency/97c8ab23aeef8fb850b8a717eaa6f91e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request implements significant refactoring to migrate the ghostcloud module from the legacy Cosmos SDK parameter store to the modern collections framework, while also updating generated protobuf files to use a new namespace structure. The changes improve code maintainability, type safety, and align with current Cosmos SDK best practices.
- Migrates parameter storage from x/params to collections framework for better type safety and performance
- Updates protobuf namespace from
ghostcloud.ghostcloudtoliftedinit.ghostcloud.v1for better organization - Refactors simulation code to use modern patterns and removes deprecated helper functions
Reviewed Changes
Copilot reviewed 82 out of 86 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| x/ghostcloud/types/tx.pb.go | Updates protobuf namespace and file descriptor references |
| x/ghostcloud/types/query.pb.go | Updates gRPC service names and protobuf namespace |
| x/ghostcloud/types/params.pb.go | Updates protobuf namespace and file descriptor |
| x/ghostcloud/keeper/keeper.go | Migrates from legacy parameter store to collections framework |
| x/ghostcloud/keeper/params.go | Replaces parameter store methods with collections-based implementations |
| x/ghostcloud/simulation/operations.go | Implements modern simulation patterns replacing deprecated approaches |
| x/ghostcloud/module.go | Updates module to support collections and removes deprecated simulation code |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This pull request introduces several significant improvements to the build system, code coverage, simulation tooling, and generated gRPC code for the project. The most notable changes include a major overhaul of the
Makefileto enhance build, test, and simulation workflows, updates to the Go version and CI configuration, and the addition of new gRPC service files. Below are the most important changes grouped by theme:Build System and CI Enhancements
Makefileto add advanced build flags, dynamic versioning, improved build tag handling, and new targets for installation, protobuf generation, and simulation. The coverage workflow now merges simulation and unit test coverage for more accurate reporting. Obsolete or redundant targets (likenancy) were removed, and thegolangci-lintversion was updated. [1] [2] [3] [4].circleci/config.ymlfrom 1.22 to 1.23.12 and commented out the security job in both the jobs and workflows sections, likely to address compatibility or performance issues. [1] [2] [3]Test Coverage and Simulation
.coverageignorepatterns for coverage filtering. [1] [2]Makefilefor running full app simulations, import/export, after-import, and determinism tests, with options for random seeds and parameterization.Generated gRPC Code
QueryandMsgservices inapi/liftedinit/ghostcloud/v1/query_grpc.pb.goandapi/liftedinit/ghostcloud/v1/tx_grpc.pb.go, respectively. These provide type-safe interfaces for interacting with the Ghostcloud module over gRPC. [1] [2]These changes collectively modernize the build and test infrastructure, improve developer productivity, and lay the groundwork for more robust service integrations.
Depends on #68