[brotli] Add brotli support backed by org.brotli.dec #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wanted to provide the same implementation but then found this PR. Unfortunately I think this project is not actively maintained anymore. A shame, really! |
|
@MonsieurBon and @Fohlen We have an actively maintained fork renamed to the BrowserUp Proxy here. We plan to add more capabilities to the proxy while keeping it's spirit alive. |
|
We just merged brotli support on our fork, the browserup proxy: https://github.com/browserup/browserup-proxy. It should be 100% compatible with the non-legacy BrowserMob API. |
|
@ericbeland Cool! I'm not currently using browsermobproxy anymore, but I informed my former colleagues about your fork and this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello dear browsermob maintainers.
I think brotli support is a very pressing feature if you want to use browsermob anywhere near 2018. However I noticed that the current #742 PR is oddly broken. This PR is cleaner as it minimally intrudes setup with org.brotli.dec (no binaries, no platform dependant code).
Please send feedback along and merge this as soon as possible.