Fix - Router navigation cancel on error or rejected "before" hook

[ruggero-nardi]

Code change description:

• Now when a "before" hook is executed, this is done inside a try-catch. This way the before hook will behave exactly as before when executed succesfully, and now it will catch errors and promise rejections.
• In the catch execution a flag is set to true to prevent a navigate function execution, this way the browser history can be reverted.
• the currentRoute is set back to the "previousRoute" to prevent incorrect future back() navigations.

Bug description:

When a route is set to do checks before navigating, the "before" hook works incorrectly when trying to prevent navigation.

• True/false returned:
  • Documentation states that a boolean can be returned, but this is not possible and won't have any effect in the code.
• String or Route returned:
  • OK
• Promise<string|Route> returned:
  • If resolve(to): Navigates away to the new route.
  • If resolve(from): Navigates to the same current route (Refreshes the current page)
  • If reject(): Error, app stucked
  • If resolve(undefinedPath): Navigation prevented, Blits error shown in console.

[CLAassistant]

All committers have signed the CLA.

[michielvandergeest]

thanks for this contribution @ruggero-nardi !

I've left a few inline comments, could you look at those? Also, this has been added for the route before hook, but not for the beforeEach hook. I guess the same behaviour when rejecting a promise would be expected there?

Other than that, great addition of functionality to the router. Thx!

[michielvandergeest]

instead of adding an extra state variable (preventHashChangeNavigation) to the router view, wouldn't it be more clean to keep this contained in the router logic itself?

in that case we would just always call Router.navigate.apply(this) and check a prevent has change variable in the router in the navigate method

[michielvandergeest]

Some changes to this portion have been made by me around the same time as your PR (see: https://github.com/lightning-js/blits/pull/502/files). We should make sure that we keep that functionality in tact

[ruggero-nardi]

Checked this, updated my dev branch with upstream dev branch and now it has all your changes plus the the additions to the router hooks

[github-actions]

Test Results: ✅ PASSED

Run at: 2025-10-21T08:03:31.469Z

Summary:
passed: 920 failed: 0 of 920 tests