Have the mock log facade not always print to stdout
#510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G8XSU
reviewed
Mar 27, 2025
| @@ -48,6 +48,7 @@ impl LogFacadeLog for MockLogFacadeLogger { | |||
| record.line().unwrap(), | |||
| record.args() | |||
| ); | |||
| #[cfg(ldk_node_test_log_print)] | |||
There was a problem hiding this comment.
isn't the real problem that we have trace level logs as default for tests?
Cant we work with debug level logs for tests?
There was a problem hiding this comment.
I guess we could also consider reducing it, but more generally there is no value in having the MockLogFacadeLogger spamming stdout, as we're really only using it to test our logging interface.
There was a problem hiding this comment.
I think we can reduce the log level and cfg-gate it so it does not clutter stdout.
enigbe
approved these changes
Mar 28, 2025
In lightningdevkit#463 we introduced a mock logger that implements the `log` facade in tests. Previously, it defaulted to always print `TRACE`-level logs to `stdout`. This however can be very spammy (especially since it includes TRACE-level logs of `electrum_client` now). Here, we make printing the log lines optional by `cfg`-gating it.
tnull
force-pushed
the
2025-03-test-log-print-cfg
branch
from
f3d9dce to
e5057f5
Compare
|
Rebased to resolve minor conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #463 we introduced a mock logger that implements the
logfacade in tests. Previously, it defaulted to always printTRACE-level logs tostdout. This however can be very spammy (especially since it includes TRACE-level logs ofelectrum_clientnow).Here, we make printing the log lines optional by
cfg-gating it.(cc @enigbe)