Skip to content

Add ChannelId pending change note; formatting #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

optout21
Copy link
Contributor

Followup to #2485 : add note about pending change, plus 2 formatting one-liners.

@optout21 optout21 force-pushed the channel-id-breaking branch from 4f791fc to a8a1044 Compare August 27, 2023 21:55
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (61d896d) 90.59% compared to head (d5d336f) 90.59%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2531   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files         110      110           
  Lines       57410    57410           
  Branches    57410    57410           
=======================================
  Hits        52008    52008           
  Misses       5402     5402           
Files Changed Coverage Δ
lightning/src/ln/channel_id.rs 100.00% <ø> (ø)
lightning/src/ln/payment_tests.rs 97.51% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@optout21 optout21 force-pushed the channel-id-breaking branch from a8a1044 to d5d336f Compare August 28, 2023 05:20
@optout21 optout21 marked this pull request as ready for review August 28, 2023 05:21
@tnull tnull merged commit 1f2ee21 into lightningdevkit:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants