Remove unused code in process_onion_failure #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 I see @arik-so was un-assigned. |
joostjager
force-pushed
the
remove-unused-code
branch
from
6dc210f to
ad05cca
Compare
arik-so
previously approved these changes
Mar 26, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
Actually, I think the info in the PR description would be helpful in the commit message. Would you mind adding that? |
joostjager
force-pushed
the
remove-unused-code
branch
from
ad05cca to
2bfb6de
Compare
joostjager
dismissed stale reviews from valentinewallace and arik-so
via
44a1d01
joostjager
force-pushed
the
remove-unused-code
branch
from
2bfb6de to
44a1d01
Compare
joostjager
requested review from
arik-so and
valentinewallace
and removed request for
arik-so
valentinewallace
approved these changes
Mar 26, 2025
joostjager
changed the title
Usage of amt_to_forward was removed in commit 24c2468 Before that, amt_to_forward was used to validate a channel update attached to the failure message.
joostjager
force-pushed
the
remove-unused-code
branch
from
44a1d01 to
0b3f0af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of amt_to_forward was removed in 24c2468
Before that, amt_to_forward was used to validate a channel update attached to the failure message.