Restore debug assertion removed due to lockorder restrictions #3943
Conversation
|
I've assigned @jkczyz as a reviewer! |
TheBlueMatt
force-pushed
the
2024-09-async-persist-claiming-from-closed-chan
branch
from
6bf3be6 to
d5e20fb
Compare
TheBlueMatt
force-pushed
the
2024-09-async-persist-claiming-from-closed-chan
branch
2 times, most recently
from
4a71e77 to
f2d885a
Compare
In 4582b20 we removed a debug assertion which tested that channels seeing HTLC claim replays on startup would be properly unblocked by later monitor update completion in the downstream chanel. We did so because we couldn't pass our lockorder tests taking a `per_peer_state` read lock to check if a channel was closed while the a `per_peer_state` read lock was already held. However, there's no actual reason for that, its just an arbitrary restriction of our lockorder tests. Here we restore the removed debug assertion by simply enabling the skipping of lockorder checking in `#[cfg(test)]` code - we don't care if there's a theoretical deadlock in test-only code as long as none of our tests actually hit it. Note that we also take this opportunity to enable deadlock detection in `no-std` tests as even `#[cfg(not(feature = "std"))]` test builds allow access to `std`.
TheBlueMatt
force-pushed
the
2024-09-async-persist-claiming-from-closed-chan
branch
from
f2d885a to
eadb70f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3943 +/- ##
==========================================
- Coverage 89.05% 89.03% -0.02%
==========================================
Files 167 167
Lines 121800 121847 +47
Branches 121800 121847 +47
==========================================
+ Hits 108464 108482 +18
- Misses 10928 10949 +21
- Partials 2408 2416 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 1st Reminder Hey @jkczyz! This PR has been waiting for your review. |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
Landing as debug-builds-assertion-only. |
In 4582b20 we removed a debug assertion which tested that channels seeing HTLC claim replays on startup would be properly unblocked by later monitor update completion in the downstream chanel.
We did so because we couldn't pass our lockorder tests taking a
per_peer_stateread lock to check if a channel was closed while the aper_peer_stateread lock was already held.However, there's no actual reason for that, its just an arbitrary restriction of our lockorder tests.
Here we restore the removed debug assertion by simply enabling the skipping of lockorder checking in
#[cfg(test)]code - we don't care if there's a theoretical deadlock in test-only code as long as none of our tests actually hit it.Note that we also take this opportunity to enable deadlock detection in
no-stdtests as even#[cfg(not(feature = "std"))]test builds allow access tostd.