Correct gossip forwarding criteria while doing background sync #4107
+81
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 I see @tankyleo was un-assigned. |
If we're doing gossip backfill to a peer, we first forward all our `channel_announcement`s and `channel_update`s in SCID-order. While doing so, we don't forward any fresh `channel_update` messages for any channels which we haven't yet backfilled (as we'll eventually send the new update anyway, and it might get rejected without the corresponding `channel_announcement`). Sadly, our comparison for this was the wrong way, so we actually *only* forwarded updates which were for channels we haven't yet backfilled, and dropped updates for channels we already had backfilled.
TheBlueMatt
force-pushed
the
2025-09-fix-forward-while-sync-order
branch
from
c5e935a to
edc7903
Compare
wpaulino
approved these changes
Sep 22, 2025
tnull
approved these changes
Sep 22, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4107 +/- ##
==========================================
+ Coverage 88.69% 88.70% +0.01%
==========================================
Files 176 176
Lines 132859 132885 +26
Branches 132859 132885 +26
==========================================
+ Hits 117836 117875 +39
+ Misses 12336 12318 -18
- Partials 2687 2692 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're doing gossip backfill to a peer, we first forward all our
channel_announcements andchannel_updates in SCID-order. While doing so, we don't forward any freshchannel_updatemessages for any channels which we haven't yet backfilled (as we'll eventually send the new update anyway, and it might get rejected without the correspondingchannel_announcement).Sadly, our comparison for this was the wrong way, so we actually only forwarded updates which were for channels we haven't yet backfilled, and dropped updates for channels we already had backfilled.