Skip to content

Conversation

@starius
Copy link
Collaborator

@starius starius commented Oct 26, 2025

loop static in --amt
loop static withdraw --amt

This is done to make it consistent with other commands and products.

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes

Copy link
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remain compatible to current automation scripts should we just add the amt flag rather than replacing the amount flag with it?

@starius starius marked this pull request as ready for review October 26, 2025 13:40
@starius
Copy link
Collaborator Author

starius commented Oct 26, 2025

@hieblmi I think we can just rename it, because the --amount flag is broken in release 0.31.4 and 0.31.5 is not released yet, so it is unlikely that somebody already uses it in automation scripts.

@starius starius requested a review from hieblmi October 26, 2025 13:42
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@bhandras bhandras self-requested a review October 26, 2025 17:37
@bhandras
Copy link
Member

Actually github.com/urfave/cli/v2 does support flag aliases, ie you can do something like this:

&cli.IntFlag{
  Name:        "amount",
  Aliases:     []string{"amt"},
}

loop static in --amt
loop static withdraw --amt

This is done to make it consistent with other commands and products.

Keep --amount flag as an alias.
@starius
Copy link
Collaborator Author

starius commented Oct 26, 2025

I added --amount as an alias.

Copy link
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@starius starius merged commit e173834 into lightninglabs:master Oct 26, 2025
11 of 12 checks passed
@starius starius deleted the static-amt branch October 26, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants