-
Couldn't load subscription status.
- Fork 122
cli: rename --amount to --amt in static #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To remain compatible to current automation scripts should we just add the amt flag rather than replacing the amount flag with it?
|
@hieblmi I think we can just rename it, because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
|
Actually |
loop static in --amt loop static withdraw --amt This is done to make it consistent with other commands and products. Keep --amount flag as an alias.
|
I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM.
This is done to make it consistent with other commands and products.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes