Skip to content

itest: add retries to reduce flakiness in balance and address checks #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

itest: add retries to reduce flakiness in balance and address checks #1799

wants to merge 2 commits into from
+78 −39

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Sep 16, 2025

This PR improves test reliability by adding retries to common race-prone checks:

  • Wrap NewAddr RPC in NewAddrWithEventStream with wait.NoError to ensure syncing is complete before returning an address.
  • Retry AssertBalances with wait.NoError to handle in-progress balance updates.

These changes reduce intermittent itest flakes caused by timing issues.

See also: #1776

ffranr and others added 2 commits September 16, 2025 14:08
@ffranr
itest: wrap NewAddr RPC call in NewAddrWithEventStream with wait.NoError
0da5424 
This function is typically called after assets have been minted by
another node, and syncing is assumed to be complete. Adding a retry here
ensures that we eventually obtain an address once syncing has actually
finished.
@linden @ffranr
itest: retry AssertBalances using wait.NoError
8b63df3 
Avoids race condition when a balance change is still in-progress.
@ffranr ffranr self-assigned this Sep 16, 2025
@ffranr ffranr added the itests label Sep 16, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17767587869

Details

  • 27 of 70 (38.57%) changed or added relevant lines in 2 files are covered.
  • 33 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+7.6%) to 57.18%
Changes Missing Coverage Covered Lines Changed/Added Lines %
itest/utils.go 7 9 77.78%
itest/assertions.go 20 61 32.79%
Files with Coverage Reduction New Missed Lines %
tapdb/multiverse.go 2 80.85%
taprpc/universerpc/universe_grpc.pb.go 2 65.45%
universe_rpc_diff.go 2 76.0%
itest/multisig.go 3 97.94%
universe/syncer.go 6 84.22%
rfq/order.go 18 57.52%
Totals Coverage Status
Change from base Build 17762935341: 7.6%
Covered Lines: 64236
Relevant Lines: 112339
💛 - Coveralls

@ffranr ffranr moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board Sep 16, 2025
@lightninglabs-deploy
Copy link

@darioAnongba: review reminder
@GeorgeTsagk: review reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darioAnongba darioAnongba Awaiting requested review from darioAnongba

@GeorgeTsagk GeorgeTsagk Awaiting requested review from GeorgeTsagk

At least 2 approving reviews are required to merge this pull request.

Assignees

@ffranr ffranr

Labels
itests no-changelog
Projects
Taproot-Assets Project Board
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ffranr @coveralls @lightninglabs-deploy @linden