[v0.20.x-branch] Backport #10356: graph: fix inefficient query for IsPublicNode #10475
+45
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit we add a benchmark to test the performance of IsPublicNode query. (cherry picked from commit 86cde4b)
In this commit we updated the IsPublicV1Node query to use UNION instead of OR, since sqlite struggles to efficiently use multiple indexes in a single query involving OR conditions across different columns. We use UNION ALL since the query doesn't care about duplicates. (cherry picked from commit ac2cec4)
ziggie1984
force-pushed
the
backport-10356-to-v0.20.x-branch
branch
2 times, most recently
from
756c3fa to
bdd0da2
Compare
(cherry picked from commit 68f558c)
ziggie1984
force-pushed
the
backport-10356-to-v0.20.x-branch
branch
from
bdd0da2 to
580e820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10356
fixes #10337 (partially)
Change Description
In this PR, we rewrite the query for
IsPublicV1Node, which returns a boolean based on if a node has a public or private channel. This particularly fixes an issuesqlitebackend as it struggles to efficiently use multiple indexes across seperate columns in one query.Step to test