multi: disable postgres db timeout setting

[ziggie1984]

Force db.postgres.timeout to always be 0 (disabled) as LND currently
does not properly retry when timeout errors occur. Any user-provided
non-zero timeout value will be overridden to 0 with a warning logged.

This is a temporary measure until proper retry logic is implemented for
postgres timeout errors. Once the retry mechanism is fixed, this
restriction can be removed to allow users to configure timeouts again.

[gemini-code-assist]

Summary of Changes

Hello @ziggie1984, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a temporary fix to prevent LND from encountering issues with Postgres database connection timeouts. It disables the db.postgres.timeout setting by forcing its value to zero, effectively removing the timeout. This is necessary because LND currently lacks robust retry mechanisms for timeout-related errors, which could lead to instability. The change also ensures that any user-configured timeout values are overridden and a warning is logged, making it clear that this setting is not currently supported.

Highlights

• Postgres Timeout Disablement: The db.postgres.timeout setting is now always forced to 0 (disabled) in LND configurations. This prevents issues arising from LND's current inability to properly retry on Postgres timeout errors.
• User Configuration Override: Any non-zero value provided by a user for db.postgres.timeout will be overridden to 0, and a warning will be logged to inform the user of this change.
• Temporary Measure: This change is a temporary solution until proper retry logic for Postgres timeout errors is implemented in LND, after which the restriction can be lifted.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request disables the db.postgres.timeout setting by forcing it to 0. This is a temporary workaround because LND does not currently handle Postgres timeout errors with proper retry logic. The changes include updating documentation in docs/postgres.md and sample-lnd.conf to reflect this, and adding logic in sqldb/config.go to override any user-provided timeout with a warning. The changes are correct and well-documented. I have one minor suggestion to improve the formatting of the warning message to better align with the project's style guide.

[gemini-code-assist]

While the log message is clear, its formatting can be improved to better align with the style guide, which prefers minimizing lines for log messages. You can combine the string concatenations to make this warning a two-line statement instead of three.

Suggested change

	log.Warnf("db.postgres.timeout is not supported and will be "+
	"ignored. LND does not properly retry on timeout "+
	"errors, so timeout is always set to 0 (disabled).")
	log.Warnf("db.postgres.timeout is not supported and will be "+
	"ignored. LND does not properly retry on timeout errors, so "+
	"timeout is always set to 0 (disabled).")

References

1. The style guide suggests minimizing lines for log and error messages. The current implementation splits the log message string across three lines, which could be condensed to two for better readability and conciseness. ^(link)