[WIP] ci: compare pipeline-parallel Eagle3 convergence - #180
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32e834e388
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (f"{mooncake_key}_hs", all_hidden[:, :split_at]), | ||
| (f"{mooncake_key}_ids", input_ids), | ||
| (f"{mooncake_key}_lhs", all_hidden[:, -self._hidden_size :]), |
There was a problem hiding this comment.
Normalize hidden states before raw publication
When vLLM is configured with dtype=float16 (supported through inference.vllm.extra_args), these cache slices remain FP16, but put_raw_tensors() performs no conversion while the connector metadata still declares every hidden-state tensor as BF16. Consumers therefore reinterpret the FP16 bytes as BF16 and silently train on corrupted values. The previous EagleMooncakeStore.put() path explicitly converted hidden and last-hidden states to HIDDEN_STATES_STORAGE_DTYPE; preserve that normalization for both the TP tuples here and the PP fragments below before publishing them.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed by normalizing hidden-state tensors to the declared storage dtype before raw publication, with regression coverage for both tensor- and pipeline-parallel layouts.
c570340 to
c0e202a
Compare
Signed-off-by: torchspec-bot <262938024+torchspec-bot@users.noreply.github.com>
c0e202a to
b905adf
Compare
Summary
Validation
Scope
This change contains no environment-specific paths, hostnames, job identifiers, benchmark claims, or credentials.