re-enable async tests round 2 #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could check for robustness if you span up a bigger build matrix using more jdks and scala versions. |
|
I meant more robust in that travis ci doesn't have spurious failures do to race conditions - I am ambivalent to increasing the number of environments we test against. |
|
Exactly. I suggest to use a bigger build matrix only on a branch to discover and debug the flaky tests. |
Voltir
force-pushed
the
add-async-tests
branch
from
841b584 to
d589157
Compare
|
To be sure, I still suggest to once temporarily span up a large travis build matrix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe travis-ci will be nice this time.