Skip to content

Added a safe assign initializer. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions Sources/TSAO.swift
Original file line number Diff line number Diff line change
Expand Up @@ -49,21 +49,37 @@ public struct AssocMap<ValueType> {
}
}

fileprivate init(_policy: objc_AssociationPolicy) {
fileprivate init(_policy: objc_AssociationPolicy, useWeakObjectContainer: Bool = false) {
precondition(!useWeakObjectContainer || _policy == .OBJC_ASSOCIATION_RETAIN)
self._policy = _policy
self.useWeakObjectContainer = useWeakObjectContainer
}

private let _policy: objc_AssociationPolicy
private let _key: _AssocKey = _AssocKey()
private let useWeakObjectContainer: Bool

private func _get(_ object: AnyObject) -> AnyObject? {
let p = Unmanaged.passUnretained(_key).toOpaque()
return objc_getAssociatedObject(object, p) as AnyObject?
if useWeakObjectContainer {
return (objc_getAssociatedObject(object, p) as? WeakObjectContainer)?.object
} else {
return objc_getAssociatedObject(object, p) as AnyObject?
}
}

private func _set(_ object: AnyObject, _ value: AnyObject?) {
let p = Unmanaged.passUnretained(_key).toOpaque()
objc_setAssociatedObject(object, p, value, _policy)
if useWeakObjectContainer {
let container = (objc_getAssociatedObject(object, p) as? WeakObjectContainer) ?? {
let new = WeakObjectContainer()
objc_setAssociatedObject(object, p, new, _policy)
return new
}()
container.object = value
} else {
objc_setAssociatedObject(object, p, value, _policy)
}
}
}

Expand All @@ -74,6 +90,11 @@ extension AssocMap where ValueType: AnyObject {
public init(assign: ()) {
self.init(_policy: .OBJC_ASSOCIATION_ASSIGN)
}

/// Initializes an `AssocMap` with a safe assign policy. Accessing the value will return nil if object has been deallocated.
public init(safeAssign: ()) {
self.init(_policy: .OBJC_ASSOCIATION_RETAIN, useWeakObjectContainer: true)
}
}

extension AssocMap where ValueType: NSCopying {
Expand Down Expand Up @@ -116,3 +137,7 @@ private final class _AssocValueBox<ValueType> {
_storage = v
}
}

private final class WeakObjectContainer {
weak var object: AnyObject?
}
13 changes: 13 additions & 0 deletions Tests/TSAOTests/Tests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ let tupleMap = AssocMap<(Int, CGRect)>()

let objectRetainMap = AssocMap<NSObject>()
let objectAssignMap = AssocMap<NSObject>(assign: ())
let objectSafeAssignMap = AssocMap<NSObject>(safeAssign: ())

class TSAOTests: XCTestCase {
var helper: NSObject!
Expand Down Expand Up @@ -100,4 +101,16 @@ class TSAOTests: XCTestCase {
}
XCTAssertNil(object)
}

func testSafeAssignValue() {
weak var object: NSObject?
autoreleasepool {
let obj = NSObject()
objectSafeAssignMap[helper] = obj
object = obj
XCTAssertEqual(obj, objectSafeAssignMap[helper])
}
XCTAssertNil(object)
XCTAssertNil(objectSafeAssignMap[helper])
}
}