Cache the OpenSSH version if it is needed again #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbjorklund
force-pushed
the
ssh-version-cache
branch
from
9af710c to
0cf341b
Compare
AkihiroSuda
reviewed
Jan 20, 2025
AkihiroSuda
reviewed
Jan 20, 2025
| Path string | ||
| Size int64 | ||
| ModTime time.Time | ||
| } |
There was a problem hiding this comment.
Maybe over engineering? idk
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
ssh-version-cache
branch
from
0cf341b to
c735660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to avoid calling it twice:
Found some hard-coded instances of "ssh", and some duplicated code for $SSH (which should be LIMA_SSH, I guess)
Added some paranoid caching of "stat" info, instead of using just the path like /usr/bin/ssh to cache the version...