Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcc line in Makefile for Linux #3182

Closed
wants to merge 1 commit into from
Closed

Conversation

fdmarcin
Copy link

I needed this change for make to succeed on Fedora 41. Not sure if this is the right way to do this, so I'm open to suggestions. I haven't tested this on other Linux distros.

As it is currently on master, I've been getting this error when trying to run make:

cgo: C compiler "x86_64-linux-gnu-gcc" not found: exec: "x86_64-linux-gnu-gcc": executable file not found in $PATH

I needed this change for `make` to succeed on Fedora 41. Not sure if this is the right way to do this, so I'm open to suggestions. I haven't tested this on other Linux distros.

Signed-off-by: Marcin Sedlak-Jakubowski <[email protected]>
@fdmarcin
Copy link
Author

@norio-nomura Hi! You were the last one to rewrite that section of the Makefile. I've no idea if my changes are correct. Would you mind taking a look? 🙇

@fdmarcin
Copy link
Author

Alright, release fails, so this is probably not the right way to fix this. I'll leave this open, but if the maintainers don't have another idea, this can be closed.

@jandubois
Copy link
Member

compiler "x86_64-linux-gnu-gcc" not found: exec: "x86_64-linux-gnu-gcc": executable file not found in $PATH

Did you trying installing the gcc-x86_64-linux package (it is a subpackage of cross-gcc)?

Your change is breaking cross-compilation, so I think this issue should be closed.

@fdmarcin fdmarcin closed this Feb 3, 2025
@afbjorklund
Copy link
Member

I don't think that we need to use the cross-compiler for the local build, only for the actual cross...

In the same way we don't need to set GOOS and GOARCH either, but just call out to go build.

It was just something that came with the caching and performance optimizations of the Makefile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants