Allow to sftp-server binary found in path #3183
Draft
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Sengileyev <[email protected]>
AkihiroSuda
reviewed
Jan 31, 2025
| @@ -64,6 +65,10 @@ func (a *HostAgent) setupMount(m limayaml.Mount) (*mount, error) { | |||
| Readonly: !(*m.Writable), | |||
| SSHFSAdditionalArgs: []string{"-o", sshfsOptions}, | |||
| } | |||
| serverPath, err := exec.LookPath("sftp-server") | |||
There was a problem hiding this comment.
This logic should be rather implemented in sshocker
There was a problem hiding this comment.
Also curious to know what distro needs this
There was a problem hiding this comment.
Also curious to know what distro needs this
It is from Windows experiment, where I put all "userland" dependencies into "_output/bin/bundle" #909 (comment) I'm exploring how feasible is it to just provide all the dependencies with Lima bundled.
This logic should be rather implemented in sshocker
I will create PR in sshocker then. Will keep this for now as a draft for references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lima allows to override majority of its dependencies (binaries) via $PATH configuration.
sftp-serveris one prominent exception.sshockerlibrary will not try to resolve path unsell OpensshSftpServerBinary param is set to non empty string and will always fallback only to well known candidates.This adds code in Lima to check if the binary could be found in path and in this case will instruct
sshockerto use it.Implementing this will allow to use Lima with an OS flavor agnostic bundle of dependencies if configured via $PATH variable.