[release/1.2] cherry-picks #3750
Merged
+110
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UDP port forwarder previously used a single gRPC stream for all clients, which could cause responses from the guest to be sent to the wrong client on the host. This occurred because the stream was created before client connections were demultiplexed by `gvisor-tap-vsock`'s `UDPProxy`. The root cause is the interaction with `gvisor-tap-vsock`'s `UDPProxy`, which handles client demultiplexing internally based on the source address of incoming datagrams. It expects its `dialer` function to return a new `net.Conn` for each new client it detects. This commit moves the gRPC stream creation into the `UDPProxy` dialer function. This ensures a new, dedicated stream is created for each new client, fixing the incorrect response routing. Signed-off-by: Viktor Oreshkin <[email protected]> (cherry picked from commit a04f244) Signed-off-by: Akihiro Suda <[email protected]>
Fix issue 3720 Thanks to pavelanni for providing the fix generated by Claude Co-authored-by: Oleksandr Redko <[email protected]> Signed-off-by: Akihiro Suda <[email protected]> (cherry picked from commit 2b8bb39) Signed-off-by: Akihiro Suda <[email protected]>
```
Error: pkg\instance\start.go:274:65: SA4023: this comparison is always true (staticcheck)
if err := syscall.Exec(limactl, haCmd.Args, haCmd.Environ()); err != nil {
```
Signed-off-by: Akihiro Suda <[email protected]>
(cherry picked from commit bdf7c7f)
> Conflicts:
> pkg/instance/start.go
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]> (cherry picked from commit 86b4495) Signed-off-by: Akihiro Suda <[email protected]>
Closed
alexandear
approved these changes
Jul 18, 2025
jandubois
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick: