Conversation
7e533db to
1c9e832
Compare
ab63c95 to
a915bb6
Compare
3806506 to
2d3e31f
Compare
jandubois
left a comment
There was a problem hiding this comment.
I don't have the energy to do a proper review today, but here are some things I noticed. Only the "boot" thing is a problem.
Another suggestion: maybe add a helper for inst.Config.OS != nil && *inst.Config.OS == limatype.DARWIN because that is used a lot. On second thought, is the nil check necessary? Because FillDefault guarantees that it isn't nil. We don't do nil checks for other fields in the driver code (or shouldn't have to).
I've wondered before why we use pointers for so many of the fields in For some, especially booleans, we want to be able to distinguish if the value was specified as the null value (i.e. Or am I missing something? |
2d3e31f to
2310def
Compare
Removed the nil check
Probably we wanted to treat all the types in the consistent manner. |
1dd42f7 to
6a73da2
Compare
|
Split plist parser to: |
This comment was marked as off-topic.
This comment was marked as off-topic.
Usage:
```
limactl create --video template:macos
limactl start macos
limactl shell macos
```
The password prompt is shown during creating an instance,
so as to run `chown root:wheel ~/.lima/_mnt/0/Library/LaunchDaemons/...`,
which is required for the `lima-macos-init` launch daemon to run.
The password for GUI login is randomly generated and
stored in `/Users/${USER}.guest/password` in the VM.
Fix issue 3618
TODOs (maybe in follow-up PRs):
- [X] Docs
- [X] Switch back the default shell to `zsh`
- [ ] Graceful `limactl stop` (currently it has to be stopped from the guest)
- [ ] Propagate additional cloud-init data
- [X] Hostname
- [X] Timezone
- [X] DNS
- [ ] CA Certificates
- [ ] Support non-plain mode
- [ ] mounts
- [ ] port forwards
- [ ] Let `limactl sudoers` generate the entry for chowning files
(`chown root:wheel ~/.lima/_mnt/0/Library/LaunchDaemons/...`)
- [ ] Support headless mode (`--video=false`)
- [ ] Support macOS in `hack/update-template.sh`
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
6a73da2 to
b4869e8
Compare
Usage:
The password prompt is shown during creating an instance, so as to run
chown root:wheel ~/.lima/_mnt/0/Library/LaunchDaemons/..., which is required for thelima-macos-initlaunch daemon to run.The password for GUI login is randomly generated and stored in
/Users/${USER}.guest/passwordin the VM.Fix #3618
TODOs (in follow-up PRs):
zshlimactl stop(currently it has to be stopped from the guest)limactl sudoersgenerate the entry for chowning files(
chown root:wheel ~/.lima/_mnt/0/Library/LaunchDaemons/...)--video=false)hack/update-template.shDepends on: