copytool: support native Windows OpenSSH#5299
Draft
jandubois wants to merge 1 commit into
Draft
Conversation
On Windows, `limactl copy` converted host paths to the Cygwin/MSYS form no matter which ssh would consume them, and it passed ControlMaster options unconditionally. Native OpenSSH cannot use that path form, and it lacks multiplexing altogether, so scp failed with "getsockname failed". Paths now go through the ssh.exe that will consume them. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
limactl copyconverted host paths to the Cygwin/MSYS form no matter which ssh would consume them, and it passed ControlMaster options unconditionally. Native OpenSSH cannot use that path form, and it lacks multiplexing altogether, so scp failed withgetsockname failed.Paths now go through the ssh.exe that will consume them.
Part of a series continuing the native Windows OpenSSH work from #5205 and #5270: #5298, #5299, #5300, #5301. They are independent and can merge in any order. #5298 and #5301 both touch
pkg/sshutil/sshutil.go, in different functions, and apply cleanly in either order.Note that the Windows CI runner uses MSYS2 / Git for Windows, so it exercises the Cygwin path.
TestParseCopyPathsWindowsDriveLetterruns there, but end-to-end validation on a plain Windows host, with no Cygwin toolchain present, arrives with the plain-Windows CI jobs in a later PR.