Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .clang-format #120

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

saurabhraghuvanshii
Copy link

@saurabhraghuvanshii saurabhraghuvanshii commented Feb 24, 2025

fixes #104

  • Add .clang-format for format file with some set rule
  • And To keep consistent format
  • refer some pre built style file ( WebKit , LLVM, Microsoft)

Test

  • test locally it work on file by running command clang-format -i <filename>

Next step

  • for automation on CI , falling if code is not formatted
  • And documentation in CONTRIBUTING.md

@jandubois
Copy link
Member

jandubois commented Feb 24, 2025

@saurabhraghuvanshii Can you please update your commits to include a DCO (see https://github.com/lima-vm/socket_vmnet/pull/120/checks?check_run_id=37732521320 for more details)

@nirs Can you do a review of the .clang-format file to see if that is what we want?

@saurabhraghuvanshii
Copy link
Author

I will sir update my commit for now my wifi is not working and my mobile data is not sufficient.

@saurabhraghuvanshii
Copy link
Author

Okay sir, I will update I am thinking of asking this. But for clear i create new file. Thanks sir

Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review more later, added some comments for now.

Signed-off-by: saurabhraghuvanshii <[email protected]>

chore: update clang-format

Signed-off-by: saurabhraghuvanshii <[email protected]>
Signed-off-by: saurabhraghuvanshii <[email protected]>
Signed-off-by: saurabhraghuvanshii <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate clang-format
3 participants