Skip to content

fix(sharing): keep empty organization drives active#4872

Merged
shepilov merged 1 commit into
masterfrom
fix/keep-empty-org-drives-active
Jul 23, 2026
Merged

fix(sharing): keep empty organization drives active#4872
shepilov merged 1 commit into
masterfrom
fix/keep-empty-org-drives-active

Conversation

@shepilov

@shepilov shepilov commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

  • Keep owner-side organization-drive sharings active when their last recipient or group is revoked.
  • Preserve the root sharing reference so empty organization drives remain in the active drive listing.
  • Cover last-recipient, last-group, and recipient re-addition behavior with regression tests.

@shepilov
shepilov marked this pull request as ready for review July 23, 2026 10:25

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're actually testing adding recipients rather than reading them, no?

Comment thread model/sharing/sharing.go

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be merged with the first commit.

Revoking the last recipient currently runs full drive cleanup before
preserving the organization-drive document. Keep these drives active so
the owner listing and root reference remain available.
@shepilov
shepilov force-pushed the fix/keep-empty-org-drives-active branch from 47b8497 to c98b47c Compare July 23, 2026 10:56
@shepilov
shepilov merged commit 5edc04b into master Jul 23, 2026
4 checks passed
@shepilov
shepilov deleted the fix/keep-empty-org-drives-active branch July 23, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants