Skip to content

feat(evaluation) 14/15: Evaluation tab on the admin System page - #825

Open
Ahmath-Gadji wants to merge 1 commit into
eval/13-ui-componentsfrom
eval/14-ui-page
Open

feat(evaluation) 14/15: Evaluation tab on the admin System page#825
Ahmath-Gadji wants to merge 1 commit into
eval/13-ui-componentsfrom
eval/14-ui-page

Conversation

@Ahmath-Gadji

@Ahmath-Gadji Ahmath-Gadji commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Part 14 of 15 of the split of #811. Targets eval/13-ui-components (#824). This is the point the feature becomes reachable — everything before it is inert.

What

EvaluationTab composes the dataset card and the run detail, owns the run history table, and is registered as a tab on the admin System page.

Notable

  • The run list is the source of truth for "is a run active". Runs are serialised server-side, so that is a property of the list, not of the dataset card — which is why runActive is computed here and passed down rather than derived twice.
  • Polling stops when nothing is active. The same EVAL_POLL_MS / isActiveStatus pair from part 12, so the list and the detail view cannot drift apart on cadence.

Testing

9 UI tests covering dataset listing, run start/cancel gating, the metric panels and error display. The full ui suite is green here: 23 files / 167 tests, 0 failures, plus tsc -b clean and eslint reporting only the warning already on develop.

Note for anyone comparing with #811: that description reported 31 pre-existing UI failures under jsdom. They do not reproduce on a clean npm ci in this environment — the suite passes in full.

What's left

Part 15 is docs and the sample dataset only — no code.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@EnjoyBacon7, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3f8c7b0e-8cf4-4265-a7fb-76ca615def21

📥 Commits

Reviewing files that changed from the base of the PR and between a8a3a05 and 7f1f006.

📒 Files selected for processing (3)
  • ui/src/pages/admin/evaluation/index.test.tsx
  • ui/src/pages/admin/evaluation/index.tsx
  • ui/src/pages/admin/system.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch eval/14-ui-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Ahmath-Gadji

Copy link
Copy Markdown
Collaborator Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 56 minutes.

`EvaluationTab` composes the dataset card and the run detail, and owns the
run history table. The run list drives both the polling cadence and whether
a new run may be started: runs are serialised server-side, so whether any
run is active is a property of the list, not of the dataset card.

Polling stops once nothing is active, rather than refetching a table that
can no longer change.

This is the point the feature becomes reachable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants