Skip to content

TF-3150 Fix cancel sending email not work as expected #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TF-3150 Fix cancel sending email not work as expected #3186

wants to merge 1 commit into from

Conversation

@dab246
Copy link
Member

@dab246 dab246 commented Oct 1, 2024

Issue

#3150

Resolved

  • Web: Sending email
sending-email.mov
  • Web: Saving email as draft
saving-email.mov
  • Mobile: Sending email
send-mobile.webm
  • Mobile: Saving email as draft
save-mobile.webm

@github-actions
Copy link

github-actions bot commented Oct 1, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/3186.

tddang-linagora
tddang-linagora previously approved these changes Oct 2, 2024
View reviewed changes
@dab246 dab246 force-pushed the bugfix/tf-3150-cancel-sending-email-not-work-as-expected branch from e143848 to df7c151 Compare October 15, 2024 05:15
@dab246 dab246 requested a review from hoangdat October 15, 2024 05:15
@hoangdat
Copy link
Member

hoangdat commented Oct 21, 2024 •
edited by dab246
Loading

  • saving/sending request was canceled, but progress dialog can not be closed

Reproduce:

  1. Setup timeout 100ms
  2. composer email
  3. saving email
  4. timeout warning was shown
  5. save again
  6. composer new
  7. saving email
    => progress cannot be close because jmap request was canceling

@dab246 dab246 force-pushed the bugfix/tf-3150-cancel-sending-email-not-work-as-expected branch 2 times, most recently from 6e41e80 to bd63898 Compare October 21, 2024 09:26
@dab246
Copy link
Member Author

dab246 commented Oct 21, 2024

  • saving/sending request was canceled, but progress dialog can not be closed

Reproduce:

  1. Setup timeout 100ms
  2. composer email
  3. saving email
  4. timeout warning was shown
  5. save again
  6. composer new
  7. saving email
    => progress cannot be close because jmap request was canceling

Fixed.

  • Use timeout of Future to avoid duplicated request delay in interceptor dio
Screen.Recording.2024-10-21.at.16.12.51.mov

@dab246 dab246 force-pushed the bugfix/tf-3150-cancel-sending-email-not-work-as-expected branch from bd63898 to 030a01b Compare October 25, 2024 04:30
hoangdat
hoangdat reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@hoangdat hoangdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my point of view, should have one more time for user retry in case of timeout (maybe we should increase timeout). After that, let user know about the problem

@dab246
Copy link
Member Author

dab246 commented Nov 7, 2024

from my point of view, should have one more time for user retry in case of timeout (maybe we should increase timeout). After that, let user know about the problem

IMO, We don't need to, because our timeout is currently 1 minute, which is long enough for sending emails. The user should wait for a response from the server afterwards.

@dab246 dab246 requested a review from hoangdat November 7, 2024 03:17
hoangdat
hoangdat reviewed Nov 19, 2024
View reviewed changes
lib/features/composer/presentation/composer_controller.dart
onConfirmAction: () {
_sendButtonState = ButtonState.enabled;
popBack();
_handleSendMessages(context: context);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens in this case if send message take very long time to process?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have timeout the first time. If the user still wants to send. We will continue to maintain until error occurs or timeout from the server.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be safe. Please add timeout with one minute when user try it again.

@dab246 dab246 requested a review from hoangdat November 19, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tddang-linagora tddang-linagora tddang-linagora approved these changes

@hoangdat hoangdat Awaiting requested review from hoangdat

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dab246 @hoangdat @tddang-linagora