Skip to content

Conversation

@thuyenh1081
Copy link
Collaborator

Ticket

this PR includes code for script "View profile of a members in a group"

Resolved

Attach screenshots or videos demonstrating the changes

Screen.Recording.2025-10-16.at.16.26.41.mov

@hoangdat
Copy link
Member

hoangdat commented Nov 2, 2025

why this PR have a lot not related commits?

@thuyenh1081
Copy link
Collaborator Author

thuyenh1081 commented Nov 3, 2025

why this PR have a lot not related commits?

I have checked and this was an accident

  • script "Search for messages inside a chat" is really a new one but I forgot create branch for it. I really forgot about this script until I create branch for script 'View profile of a members in a group'. Therefore, it is true that this check include code for 2 scripts "Search for messages inside a chat" and ''View profile of a members in a group'. I didn't intent to do that. That is an accident. Sorry for that
  • The script "Pin/unpin a chat" is already included in the previous PR (PinUnpinChat). This branch was created from that branch, so since PinUnpinChat hasn’t been merged into main yet, you will still see its code here. Please review and merge PinUnpinChat first.

@hoangdat
Copy link
Member

hoangdat commented Nov 3, 2025

  • you should separate the logic between PRs, if the new one still depend on the previous ones, this is so risky and will make team review and review again.

@thuyenh1081 thuyenh1081 closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants