Merged
Conversation
odanado
force-pushed
the
add-deprecated-tag-ngrok-v1
branch
from
3fa1955 to
3c289d0
Compare
odanado
changed the title
@deprecated to NgrokV1Proxy@deprecated to NgrokV1Proxy
kazuma0129
reviewed
Jun 5, 2025
| console.warn("ngrok-v1 is experimental feature."); | ||
| console.warn( | ||
| `proxyType 'ngrok-v1' is deprecated. Please use 'ngrok' instead.`, | ||
| ); |
Member
There was a problem hiding this comment.
https://github.com/line/liff-cli/blob/add-deprecated-tag-ngrok-v1/src/serve/commands/index.ts#L22
I think it would be fine to remove it from this description. What do you think?
kazuma0129
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #17, the LIFF CLI gained support for the latest version of ngrok.
Therefore, there is no longer any need to use the older version,
ngrok-v1.