Skip to content

feat: Add get_follower_ids tool #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kkdai
Copy link
Member

@kkdai kkdai commented Apr 27, 2025

Resolve #15

This pull request introduces a new feature to retrieve the user IDs of followers of a LINE Official Account, along with documentation updates and minor fixes. The key changes include the addition of the get_follower_ids tool, updates to the English and Japanese README files to document this feature, and a minor code import adjustment.

New Feature: get_follower_ids Tool

  • Added a new tool, get_follower_ids, to fetch user IDs of users who have added the LINE Official Account as a friend. This includes support for pagination and limits. The implementation uses the LINE Messaging API and handles errors gracefully. (src/index.ts, src/index.tsR217-R241)
  • Imported axios to facilitate API requests for the new tool. (src/index.ts, src/index.tsR24)

Documentation Updates

  • Updated both README.md and README.ja.md to include details about the get_follower_ids tool, including inputs, return values, and usage notes. [1] [2]
  • Added minor formatting and consistency improvements to the documentation, such as fixing a link format and improving clarity. [1] [2] [3] [4] [5]

These changes enhance the functionality of the project by providing a new way to interact with LINE Official Accounts while improving the clarity and usability of the documentation.

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2025

CLA assistant check
All committers have signed the CLA.

@Yang-33 Yang-33 requested a review from eucyt April 28, 2025 02:36
@eucyt
Copy link
Contributor

eucyt commented Apr 30, 2025

Thank you! I'll check this.

Copy link
Contributor

@eucyt eucyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, and I'm sorry for the delay in my review (we had a holiday in Japan).

I’ve left a few comments, so please take a look.
Also, please resolve the conflicts as well 🙏

@kkdai kkdai changed the title Add get_follower_ids tool feat: Add get_follower_ids tool May 16, 2025
@kkdai kkdai force-pushed the get-follower branch 3 times, most recently from 3edcb80 to bcc2937 Compare May 16, 2025 13:52
kkdai added a commit to kkdai/line-bot-mcp-server that referenced this pull request May 16, 2025
line#40)

Update src/index.ts

Co-authored-by: Yuta Euchi <[email protected]>

Update src/index.ts

Co-authored-by: Yuta Euchi <[email protected]>

Update src/index.ts

Co-authored-by: Yuta Euchi <[email protected]>

Update README.md

Co-authored-by: Yuta Euchi <[email protected]>

Update README.ja.md

Co-authored-by: Yuta Euchi <[email protected]>

Update README.ja.md

Co-authored-by: Yuta Euchi <[email protected]>

chore(deps): update pnpm to v10.11.0 (line#67)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update dependency @types/node to v22.15.18 (line#69)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency @modelcontextprotocol/sdk to v1.11.3 (line#70)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update README.md

Co-authored-by: Yuta Euchi <[email protected]>

✨ Add get_follower_ids tool to retrieve user IDs of followers for LINE Official Account

📝 Update README.ja.md to remove redundant information and clarify get_follower_ids tool details.

refactor(code): remove unused get_message_quota tool
@kkdai
Copy link
Member Author

kkdai commented May 16, 2025

@eucyt
Hi
Sorry for the waiting, could you please help to review again?

Copy link
Contributor

@eucyt eucyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
In addition, please resolve conflict in package-lock.json by update base branch

Comment on lines -54 to -55
LINE公式アカウントをお持ちであれば、[こちらの手順](https://developers.line.biz/ja/docs/messaging-api/getting-started/#using-oa-manager)に従ってMessaging APIを有効にしてください。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This not should be removed.

- LINE公式アカウントを友だち追加したユーザーのユーザーID一覧を取得します。
- **入力:**
- `start` (string?): ページネーション用の継続トークン。省略時は先頭から取得します。
- `limit` (number?): 取得するユーザーIDの最大数(1~1000)。デフォルトは1000。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `limit` (number?): 取得するユーザーIDの最大数(1~1000)。デフォルトは1000
- `limit` (number?): 取得するユーザーIDの最大数(1~1000)。デフォルトは300

- Gets the list of User IDs of users who have added your LINE Official Account as a friend.
- **Inputs:**
- `start` (string?): Continuation token for pagination. If omitted, fetches from the beginning.
- `limit` (number?): Maximum number of user IDs to retrieve (1-1000). Default is 1000.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `limit` (number?): Maximum number of user IDs to retrieve (1-1000). Default is 1000.
- `limit` (number?): Maximum number of user IDs to retrieve (1-1000). Default is 300.

Comment on lines +24 to +25
import pkg from "../package.json" with { type: "json" };
import axios from "axios";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import pkg from "../package.json" with { type: "json" };
import axios from "axios";

kkdai added 2 commits May 20, 2025 12:25
line#40)

Update src/index.ts

Co-authored-by: Yuta Euchi <[email protected]>

Update src/index.ts

Co-authored-by: Yuta Euchi <[email protected]>

Update src/index.ts

Co-authored-by: Yuta Euchi <[email protected]>

Update README.md

Co-authored-by: Yuta Euchi <[email protected]>

Update README.ja.md

Co-authored-by: Yuta Euchi <[email protected]>

Update README.ja.md

Co-authored-by: Yuta Euchi <[email protected]>

chore(deps): update pnpm to v10.11.0 (line#67)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update dependency @types/node to v22.15.18 (line#69)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency @modelcontextprotocol/sdk to v1.11.3 (line#70)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update README.md

Co-authored-by: Yuta Euchi <[email protected]>

✨ Add get_follower_ids tool to retrieve user IDs of followers for LINE Official Account

📝 Update README.ja.md to remove redundant information and clarify get_follower_ids tool details.

refactor(code): remove unused get_message_quota tool
@eucyt
Copy link
Contributor

eucyt commented May 21, 2025

@kkdai
Please run npm run format and commit the diff to pass CI 🙏

(Actually this is not friendly to developer. I'll handle this issue #80 )

@Yang-33
Copy link
Contributor

Yang-33 commented Jun 9, 2025

@kkdai ping

@eucyt
Copy link
Contributor

eucyt commented Jun 9, 2025

@kkdai
We refactored dir struction to avoid conflict. So check this development flow for detail please 🙇
https://github.com/line/line-bot-mcp-server/blob/ee1196bc33c1d9ca40c75e67fa044734a8d8602b/CONTRIBUTING.md#add-a-new-tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a tool to get user id list of followers
4 participants