Add a command to query a validator for a certificate#6037
Open
bart-linera wants to merge 1 commit intolinera-io:testnet_conwayfrom
Open
Add a command to query a validator for a certificate#6037bart-linera wants to merge 1 commit intolinera-io:testnet_conwayfrom
bart-linera wants to merge 1 commit intolinera-io:testnet_conwayfrom
Conversation
afck
approved these changes
Apr 16, 2026
| ); | ||
|
|
||
| let result = node | ||
| .download_certificates_by_heights(chain_id, vec![height]) |
Contributor
There was a problem hiding this comment.
(I think that processes/preprocesses the block, does it? It's probably fine, but we could also just download, print and forget it. Not sure what's better.)
Contributor
Author
There was a problem hiding this comment.
I don't think it does, it seems to only call the method on the GRPC client as far as I can tell, but I may be wrong.
| match result { | ||
| Ok(certificates) => { | ||
| let block = certificates[0].block(); | ||
| println!("{:#?}", block); |
Contributor
There was a problem hiding this comment.
Should it be called query-block then?
Because this specifically prints only the block and not the signatures or even signatories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We could use a way of inspecting blocks without downloading whole chains from validators.
Proposal
Add a command to the client which uses
download_certificates_by_heightto download a single certificate from a given validator and display the block.Test Plan
CI will catch possible regressions.
The command has been succesfully used manually.
Release Plan
mainbranchLinks