-
Notifications
You must be signed in to change notification settings - Fork 25
Upgrade swc_core to 46.0.3 #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade swc_core to 46.0.3 #170
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 92.45% 92.17% -0.28%
==========================================
Files 8 8
Lines 1351 1355 +4
==========================================
Hits 1249 1249
- Misses 102 106 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@nathaniel-furniss-glean thank you for the contribution! Could you please update the compatibility table in the Readme? |
Happily. Will the next version be 5.7.0? |
|
@nathaniel-furniss-glean yes, 5.7.0 |
Done! |
|
@andrii-bodnar any other changes I should make? |
|
@nathaniel-furniss-glean thank you! Looks good to me @timofei-iatsenko could you please also take a look? |
|
Checking this, sw_core 46.0.3 update will break the latest Nextjs releases. And there won't be a compatible version for nextjs Can we have versions for each compat range?
WDT? I can help with the other PRs. |
|
@zombispormedio this is the way to go. We should bump and release one by one to have as much coverage as possible |
# Conflicts: # Cargo.lock # Cargo.toml # README.md
|
For my vite/react project (setup like this https://lingui.dev/installation?transpiler=swc#vite), I am able to use 5.8.0 but not 5.9.0. Based on the comment above that sounds fine but couldn't really find much information here related to it? I can open an issue if you want to discuss in an issue instead of a PR too |
|
@xconverge this is a reality of the SWC plugins, they SWC runtime is not following semver for the plugins api, and you have to choose a fixed version compatible with runtime version you have. |
Rspack 1.6.x requires swc_core range of
@46.0.0 - < 47.0.0. Updated the version to unblock upgrades.Ran tests locally, they all passed. Not a rust expert, so apologies if Cursor made any mistakes. Fixes #169