Skip to content

Conversation

@nathaniel-furniss-glean
Copy link
Contributor

Rspack 1.6.x requires swc_core range of @46.0.0 - < 47.0.0. Updated the version to unblock upgrades.

Ran tests locally, they all passed. Not a rust expert, so apologies if Cursor made any mistakes. Fixes #169

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.17%. Comparing base (5ad4277) to head (62b86e1).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ast_utils.rs 70.00% 3 Missing ⚠️
src/jsx_visitor.rs 57.14% 3 Missing ⚠️
src/macro_utils.rs 93.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   92.45%   92.17%   -0.28%     
==========================================
  Files           8        8              
  Lines        1351     1355       +4     
==========================================
  Hits         1249     1249              
- Misses        102      106       +4     
Flag Coverage Δ
unittests 92.17% <78.12%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/macro_utils.rs 88.10% <93.33%> (ø)
src/ast_utils.rs 83.68% <70.00%> (-1.93%) ⬇️
src/jsx_visitor.rs 88.33% <57.14%> (-0.44%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrii-bodnar
Copy link
Contributor

@nathaniel-furniss-glean thank you for the contribution! Could you please update the compatibility table in the Readme?

@nathaniel-furniss-glean
Copy link
Contributor Author

@nathaniel-furniss-glean thank you for the contribution! Could you please update the compatibility table in the Readme?

Happily. Will the next version be 5.7.0?

@andrii-bodnar
Copy link
Contributor

@nathaniel-furniss-glean yes, 5.7.0

@nathaniel-furniss-glean
Copy link
Contributor Author

@nathaniel-furniss-glean yes, 5.7.0

Done!

@nathaniel-furniss-glean
Copy link
Contributor Author

@andrii-bodnar any other changes I should make?

@andrii-bodnar
Copy link
Contributor

@nathaniel-furniss-glean thank you! Looks good to me

@timofei-iatsenko could you please also take a look?

@zombispormedio
Copy link
Contributor

zombispormedio commented Dec 6, 2025

Checking this, sw_core 46.0.3 update will break the latest Nextjs releases. And there won't be a compatible version for nextjs 15.5 and 16. AFAIK, lingui/swc-plugin only supports Next.js 15.4.

Can we have versions for each compat range?

5.7 -> @33.0.0 - < 40.0.0 (Next.js 15.5 support) https://plugins.swc.rs/versions/range/426
5.8 -> @40.0.0 - < 46.0.0 (Next.js 16 support) https://plugins.swc.rs/versions/range/497
5.9 -> @46.0.0 - < 47.0.0 (Rspack 1.6) https://plugins.swc.rs/versions/range/713

WDT?

I can help with the other PRs.

@timofei-iatsenko
Copy link
Collaborator

@zombispormedio this is the way to go. We should bump and release one by one to have as much coverage as possible

# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	README.md
@andrii-bodnar andrii-bodnar merged commit 8ae182e into lingui:main Dec 8, 2025
3 checks passed
@nathaniel-furniss-glean nathaniel-furniss-glean deleted the upgrade-swc-core branch December 8, 2025 19:02
@xconverge
Copy link

For my vite/react project (setup like this https://lingui.dev/installation?transpiler=swc#vite), I am able to use 5.8.0 but not 5.9.0. Based on the comment above that sounds fine but couldn't really find much information here related to it? I can open an issue if you want to discuss in an issue instead of a PR too

@timofei-iatsenko
Copy link
Collaborator

@xconverge this is a reality of the SWC plugins, they SWC runtime is not following semver for the plugins api, and you have to choose a fixed version compatible with runtime version you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not compatible with Rspack 1.6 (swc_core 46)

5 participants