Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assert #96

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Remove assert #96

merged 2 commits into from
Jan 24, 2025

Conversation

jogrogan
Copy link
Collaborator

@jogrogan jogrogan commented Jan 24, 2025 •
edited
Loading

RelOptUtil.equal effectively calls areRowTypesEqual under the hood. With the change in #94 this check is no longer valid because the query types are always going to be a subset of the sink types now. We can probably add some validation to assert this but this check is no longer enough as is.

@jogrogan jogrogan merged commit 9ee160d into main Jan 24, 2025
1 check passed
@jogrogan jogrogan deleted the jogrogan/assert branch January 24, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryannedolan ryannedolan ryannedolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jogrogan @ryannedolan