feat(FLCE): expose accum_dtype for hf model monkey patch
#851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tcc0403
force-pushed
the
tcc/accum_dtype_monkey_patch
branch
from
e0ca830 to
9e0456e
Compare
Signed-off-by: Tcc0403 <[email protected]>
Tcc0403
force-pushed
the
tcc/accum_dtype_monkey_patch
branch
from
9e0456e to
a0b849e
Compare
shimizust
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up to #830, exposing
accum_dtypeoption for monkey patch functions.All bf16 convergence tests related to fused linear cross entropy are also enforced to run with
accum_dtype=torch.float32for numerical stability.Related: #512, #742, #827, #850
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence