Skip to content

Filter out redundant ops/allocations in no_grad mode #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2025
Merged

Filter out redundant ops/allocations in no_grad mode #906

merged 3 commits into from
Oct 16, 2025

Conversation

@Tcc0403
Copy link
Collaborator

@Tcc0403 Tcc0403 commented Oct 11, 2025 •
edited
Loading

Summary

follow-up #894

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

shimizust
shimizust approved these changes Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@shimizust shimizust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shimizust shimizust merged commit c856fba into main Oct 16, 2025
5 of 7 checks passed
@shimizust shimizust deleted the tcc/flce-eval branch October 16, 2025 05:57
@keatonelvins keatonelvins mentioned this pull request Nov 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shimizust shimizust shimizust approved these changes

@lancerts lancerts Awaiting requested review from lancerts

@momochen momochen Awaiting requested review from momochen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tcc0403 @shimizust