Repository navigation
Guard streaming metrics accumulator registration - #181
Merged
cirquare merged 1 commit intoOct 6, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replay/adapt the LI streaming accumulator lifecycle fix for Beam 2.75. In streaming Flink
DoFnOperator, task cancellation/failover close no longer registers the full Beam metrics accumulator; metrics are registered for pipeline results only afterfinish()/end-of-input. Batch behavior is preserved.This prevents cancelled streaming subtasks from attaching large Beam metrics state to Flink final execution state, which can make JobManager status snapshots merge/render huge accumulator payloads during failover recovery.
Testing Done
./gradlew :runners:flink:1.20:test --tests org.apache.beam.runners.flink.translation.wrappers.streaming.DoFnOperatorTest.testAccumulatorRegistrationOnOperatorClose --tests org.apache.beam.runners.flink.translation.wrappers.streaming.DoFnOperatorTest.testAccumulatorRegistrationOnCancelInBatch --tests org.apache.beam.runners.flink.translation.wrappers.streaming.DoFnOperatorTest.testAccumulatorRegistrationAfterFinishInStreaming --tests org.apache.beam.runners.flink.translation.wrappers.streaming.DoFnOperatorTest.testNoAccumulatorRegistrationOnCancelInStreaming --no-daemon -Dorg.gradle.java.home=$(/usr/libexec/java_home -v 11.0.21)./gradlew :runners:flink:2.2:test --tests org.apache.beam.runners.flink.translation.wrappers.streaming.DoFnOperatorTest.testAccumulatorRegistrationOnOperatorClose --tests org.apache.beam.runners.flink.translation.wrappers.streaming.DoFnOperatorTest.testAccumulatorRegistrationOnCancelInBatch --tests org.apache.beam.runners.flink.translation.wrappers.streaming.DoFnOperatorTest.testAccumulatorRegistrationAfterFinishInStreaming --tests org.apache.beam.runners.flink.translation.wrappers.streaming.DoFnOperatorTest.testNoAccumulatorRegistrationOnCancelInStreaming --no-daemon -Dorg.gradle.java.home=$(/usr/libexec/java_home -v 11.0.21)./gradlew :runners:flink:1.20:test :runners:flink:2.2:test --tests org.apache.beam.runners.flink.translation.wrappers.streaming.DoFnOperatorTest --no-daemon -Dorg.gradle.java.home=$(/usr/libexec/java_home -v 11.0.21)./gradlew :runners:flink:1.19:build --no-daemon -Dorg.gradle.java.home=$(/usr/libexec/java_home -v 11.0.21)./gradlew :runners:flink:1.20:build :runners:flink:2.2:build --no-daemon -Dorg.gradle.java.home=$(/usr/libexec/java_home -v 11.0.21)./gradlew :runners:flink:2.0:build --no-daemon -Dorg.gradle.java.home=$(/usr/libexec/java_home -v 11.0.21)./gradlew :runners:flink:2.1:build --no-daemon -Dorg.gradle.java.home=$(/usr/libexec/java_home -v 11.0.21)git diff --checkNote: an initial optional combined
:runners:flink:1.19:build :runners:flink:2.1:buildrun timed out once inPortableStateExecutionTest > testExecution[streaming: false]; rerunning the failing test class and then full:runners:flink:1.19:buildpassed.