Repository navigation
Fix Avro 1.11 test compile breaking publish; bump to 2.45.62 - #188
Merged
Merged
Conversation
The 2.45.61 post-merge publish (run 37264486966) failed at :sdks:java:io:google-cloud-platform:compileTestJava because Avro 1.11 made Schema.Field#defaultValue() package-private. Publishing builds test jars, so the failure blocked publication of io-google-cloud-platform and the beam-auto-elr umbrella, leaving a partial 2.45.61 on JFrog and stalling auto-ELR. Use the public defaultVal() (same as upstream apache#30638) and bump to 2.45.62 so the publish re-triggers on a clean version. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
cirquare
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The post-merge
LI JFrog Artifactory Publishrun for 2.45.61 (PR #180), run 37264486966, failed:PR #180 migrated Avro 1.8.2 -> 1.11.4. In Avro 1.11,
Schema.Field#defaultValue()(returnsJsonNode) is package-private;public Object defaultVal()replaces it. The publish builds test jars (testJarartifact inBeamModulePlugin.groovy), so test sources must compile. The publish command runs without--continue, soio-google-cloud-platformand thebeam-auto-elrumbrella were never published. That left a partial 2.45.61 on JFrog (core, model-pipeline and runners-flink-1.18 are present) and stalled auto-ELR.Fix (3 files, 4 lines)
BigQueryAvroUtilsTest.java:field.defaultValue()->field.defaultVal(). Upstream made the identical change in update confluent dependency version to 7.6.0 apache/beam#30638../update_version.sh 2.45.62(gradle.propertiesversion/sdk_version, andBeamModulePlugin.groovyproject.version). We use a fresh version so the publish does not collide with the partial 2.45.61. ChangingBeamModulePlugin.groovyalso re-triggers the publish workflow on merge.No dependency, workflow or auto-elr module-list changes.
Validation
All runs were local on JDK 8 (Zulu 1.8.0_504, matching the workflow's JDK 8), from a clean tree with
--no-build-cache../gradlew publishMavenJavaPublicationToMavenLocal -PisRelease -PnoSigning -PisLinkedin --continue --no-daemon --no-build-cache-> BUILD SUCCESSFUL in 17m 4s (1052 tasks, 0 failed). It used--continueso that any further Avro 1.11 breakages would surface; none did.beam-auto-elr:2.45.62was published, and its POM references all 22 modules fromauto-elr/build.gradleat 2.45.62. Each of those modules has a 2.45.62 POM, jar and-tests.jar(85com.linkedin.beamartifacts in total).error: cannot find symbollines (Watch.java:174,CoGroup.java:645,JdbcIO,ParquetIO, …) are javadoc-only noise and do not fail the build. They also appear in the CI log../gradlew :sdks:java:io:google-cloud-platform:test --tests '*BigQueryAvroUtilsTest*'-> 6/6 passed, includingtestConvertGenericRecordToTableRow, which exercisesdefaultVal().Known follow-up (not in scope)
Publishing compiles tests but does not run them. Upstream apache#30638 also adjusted these tests for Avro 1.11 behavior, so they likely fail when tests are run. They were not run here:
PubsubClientTest:208: the expected exception changes fromNullPointerExceptiontoSchemaParseException.GcpApiSurfaceTest:125: dropclassesInPackage("org.codehaus.jackson").A separate follow-up should also add a
compileTestJavaPR gate so this class of failure is caught before merge.CHANGES.mdwith noteworthy changes: N/A, this is a LinkedIn-fork build fix and version bump with no user-facing change.Build health: the post-merge publish result will show under the
LI JFrog Artifactory Publishworkflow onli_trunk.