Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #70. Fix help parsing in Client to avoid triggering when -hadoop_binary_path is the first option. #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Closes #70. Fix help parsing in Client to avoid triggering when -hadoop_binary_path is the first option. #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dynamometer-infra/src/main/java/com/linkedin/dynamometer/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,12 +335,12 @@ private void printUsage() {
*/
public boolean init(String[] args) throws ParseException, IOException {

CommandLineParser parser = new GnuParser();
if (parser.parse(new Options().addOption("h", "help", false, "Shows this message."), args, true).hasOption("h")) {
if (Arrays.stream(args).anyMatch(arg -> arg.equalsIgnoreCase("-h") || arg.equals("--help"))) {
printUsage();
return false;
}

CommandLineParser parser = new GnuParser();
CommandLine cliParser = parser.parse(opts, args);

yarnClient = YarnClient.createYarnClient();
Expand Down