Repository navigation
fix(inject): keep exact milliseconds in proxy timeout annotations - #15736
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
The proxy-outbound-connect-timeout, proxy-inbound-connect-timeout and shutdown-grace-period annotations are converted to milliseconds with int(duration.Seconds()*1000). Many durations are not exactly representable as float64 seconds, so the truncation drops a millisecond: 1001ms becomes 1000ms, 2.47s becomes 2469ms and 4060ms becomes 4059ms. Use duration.Milliseconds(), which does integer arithmetic on the nanosecond count. Add a TestGetOverriddenValues case that fails before the change and passes after it. Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
proxy-outbound-connect-timeout,proxy-inbound-connect-timeoutandshutdown-grace-periodannotations are converted to milliseconds withint(duration.Seconds()*1000). Many durations are not exactly representable as float64 seconds, so the truncation drops a millisecond:1001msbecomes1000ms,2.47sbecomes2469msand4060msbecomes4059ms.Use
duration.Milliseconds(), which does integer arithmetic on the nanosecond count.Validation:
TestGetOverriddenValuescase with the three values above. It fails before the change (1000ms != 1001ms,2469ms != 2470ms,4059ms != 4060ms) and passes after it.go test ./pkg/inject/ ./cli/cmd/ ./controller/webhook/... ./controller/proxy-injector/...passes.gofmt -landgo vet ./pkg/inject/report nothing.Fixes #15735
Signed-off-by: Raphael Fakhri 153192858+RaphaelFakhri@users.noreply.github.com