Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct/update poetry config #119

Merged
merged 1 commit into from
Jan 8, 2025
Merged

docs: correct/update poetry config #119

merged 1 commit into from
Jan 8, 2025

Conversation

noelmcloughlin
Copy link
Contributor

This PR is minor fix and improvement to poetry install/configuration section in README.

Discussed in #118

@noelmcloughlin noelmcloughlin marked this pull request as draft August 19, 2024 13:08
@noelmcloughlin
Copy link
Contributor Author

noelmcloughlin commented Aug 19, 2024 •
edited
Loading

Seems private repositories go into project pyproject.toml and config.toml is not supported, see python-poetry/poetry#5958

@dalito
Copy link
Member

dalito commented Aug 19, 2024 •
edited
Loading

Ok. I had another look how I did it. I am using a plugin poetry-plugin-pypi-mirror. Sorry, completely forgot about it.

@noelmcloughlin noelmcloughlin force-pushed the poetry branch 2 times, most recently from 594f2e9 to d1ae034 Compare August 19, 2024 16:45
@noelmcloughlin noelmcloughlin marked this pull request as ready for review August 19, 2024 16:50
@noelmcloughlin
Copy link
Contributor Author

I think this text is best solution for now

dalito
dalito approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@dalito dalito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and is ready to merge in my opinion. I use the described config at work.

The plugin poetry-plugin-pypi-mirror is also Poetry-2.0 ready.

@sierra-moxon sierra-moxon merged commit 77f82ea into linkml:main Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalito dalito dalito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noelmcloughlin @dalito @sierra-moxon