-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Poetry 2.0 #128
Update to Poetry 2.0 #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this looks good to me! Consider the bounding I mention in my review and merge what you think is prudent. I'm no expert on the release cycle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
I just had one recommendation on how dev dependencies are being specified.
5f108b1
to
6b7bd11
Compare
Made the requested changes and rebased on current main. Now ready to go in! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks
I have tested Poetry-2.0 in our repo here nfdi4cat/pid4cat-model#36. This PR switches as much as possible to the PEP 621 standard. The few remaining
[tool.poetry....]
sections cannot be converted to PEP 621 but have to stay.To install the development packages, run
poetry install --with=dev
. Usingpoetry install
only installs the minimum which is the model and the linkml-runtime.Due to PEP 621 conformance switching to Poetry 2.0 is also a good first step to move to uv next 😄