Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Poetry 2.0 #128

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Update to Poetry 2.0 #128

merged 3 commits into from
Jan 10, 2025

Conversation

dalito
Copy link
Contributor

@dalito dalito commented Jan 8, 2025

I have tested Poetry-2.0 in our repo here nfdi4cat/pid4cat-model#36. This PR switches as much as possible to the PEP 621 standard. The few remaining [tool.poetry....] sections cannot be converted to PEP 621 but have to stay.

To install the development packages, run poetry install --with=dev. Using poetry install only installs the minimum which is the model and the linkml-runtime.

Due to PEP 621 conformance switching to Poetry 2.0 is also a good first step to move to uv next 😄

Copy link
Contributor

@amc-corey-cox amc-corey-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks good to me! Consider the bounding I mention in my review and merge what you think is prudent. I'm no expert on the release cycle.

{{cookiecutter.project_name}}/pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@pkalita-lbl pkalita-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

I just had one recommendation on how dev dependencies are being specified.

{{cookiecutter.project_name}}/pyproject.toml Outdated Show resolved Hide resolved
{{cookiecutter.project_name}}/pyproject.toml Outdated Show resolved Hide resolved
@dalito dalito force-pushed the poetry-2.0 branch 2 times, most recently from 5f108b1 to 6b7bd11 Compare January 8, 2025 21:07
@dalito
Copy link
Contributor Author

dalito commented Jan 8, 2025

Made the requested changes and rebased on current main. Now ready to go in!

Copy link
Contributor

@pkalita-lbl pkalita-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@pkalita-lbl pkalita-lbl merged commit 1094cf2 into linkml:main Jan 10, 2025
1 check passed
@dalito dalito deleted the poetry-2.0 branch January 10, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants