Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generators): allow java/ts/owl gen via makefile #69

Closed
wants to merge 1 commit into from
Closed

feat(generators): allow java/ts/owl gen via makefile #69

wants to merge 1 commit into from

Conversation

noelmcloughlin
Copy link
Contributor

@noelmcloughlin noelmcloughlin commented May 17, 2023

This PR allows user to trigger java and typescript generators via config.env and make setup because user might want them but gen-project excludes. Additional user can re-trigger owl generator if linkml/linkml#1453 is an issue.

Changes are transparent to existing users.

Once owl bug is fixed and gen-project includes java/ts then most of this PR could be reverted.

@cmungall cmungall requested a review from sierra-moxon May 19, 2023 21:02
@sierra-moxon
Copy link
Member

Hi @noelmcloughlin - I'm confused at the difference between this PR and this one: https://github.com/linkml/linkml-project-cookiecutter/blob/main/%7B%7Bcookiecutter.project_name%7D%7D/config.yaml :) can you help me figure out why we need both config.env and config.yaml? (maybe its just ease of use for folks more comfortable with env file vs. yaml?)

@noelmcloughlin
Copy link
Contributor Author

noelmcloughlin commented May 20, 2023

Ideally config.yaml is enough and make setup and make gendoc are exhaustive.

However there are 3 issues where expected behavior does not match actual.

For long time I planned doing linkml demo to some colleagues, but working through few things first. So this project is good starting point - however, I would prefer not to maintain my own fork to address issues, so I proposed config.env as short term workaround.

I'm also willing to raise issues for above and link to this PR

This fixes linkml-validate issue that failed with Unknown arguments linkml/linkml#1495
@noelmcloughlin
Copy link
Contributor Author

I corrupted my branch so closing - will have to redo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants