Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support isodate ending with Z #357

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dalito
Copy link
Contributor

@dalito dalito commented Jan 9, 2025

The PR switches to using isodate package for isodate parsing. It is already installed with LinkML since it is a rdflib dependency.

Todo (maybe):

  • restrict the use of the isodate package to Python < 3.11. Starting with Python 3.11 the standard library´s datetime.datetime.fromisoformat is able parse isodates ending with "Z" correctly.

Closes linkml/linkml#2096
Closes linkml/linkml#629

@dalito dalito changed the title Add isodate ending with Z to tests Support isodate ending with Z Jan 9, 2025
@dalito dalito marked this pull request as ready for review January 9, 2025 22:34
isodate is already installed since it is a rdflib dependency
@dalito dalito force-pushed the issue2096-isodate-with-Z branch from c03b4a3 to 2d04371 Compare January 11, 2025 11:11
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.46%. Comparing base (1b5e9f7) to head (7aad389).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
linkml_runtime/utils/metamodelcore.py 81.81% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   63.43%   63.46%   +0.02%     
==========================================
  Files          63       63              
  Lines        8982     8989       +7     
  Branches     2574     2578       +4     
==========================================
+ Hits         5698     5705       +7     
- Misses       2665     2667       +2     
+ Partials      619      617       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant