Consistent datetime parsing across all py-versions #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was about to say, "Hey, let's do a quick PR to remove the py3.8 support whilst we're at it!" but a short search turned up this monster... |
ialarmedalien
approved these changes
Feb 24, 2025
|
@ialarmedalien it's a normal pull request I swear lol. |
sneakers-the-rat
approved these changes
Feb 24, 2025
amc-corey-cox
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old Python versions before 3.11 have to use the isodate-package for parsing ISO 8601 date-times. Newer versions use
datetime.fromisoformat. Both differ in handling of dates like "2025-02-24": Error in isodate-package, parsed to "2025-02-24T00:00:00" withdatetime.fromisoformat. This PR makes the behavior the same across the supported Python versions.The issue was observed in the PR #350.