Implement support for VPC Dual Stack #524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
commented
Apr 2, 2025
Comment on lines
+75
to
+80
| put_class: ClassVar[Optional[Type["JSONObject"]]] = None | ||
| """ | ||
| An alternative JSONObject class to use as the schema for PUT requests. | ||
| This prevents read-only fields from being included in PUT request bodies, | ||
| which in theory will result in validation errors from the API. | ||
| """ |
There was a problem hiding this comment.
I added this specifically to prevent the read-only ConfigInterface(...).ipv6.slaac.address field from being sent along in PUT requests, which would in theory result in a validation error. This was not implemented at the Property level because it needs to function recursively.
Assuming we're okay with this solution, do we think this is worth splitting into a separate PR against dev in case we want to reuse it elsewhere?
lgarber-akamai
commented
Apr 2, 2025
Comment on lines
+171
to
+172
| if is_put and cls.put_class is not None: | ||
| cls = cls.put_class |
There was a problem hiding this comment.
This is super hacky but much more efficient than serializing, loading, and re-serializing the data. If anyone has an ideas to clean this up please let me know!
lgarber-akamai
force-pushed
the
new/vpc-dual-stack
branch
from
0db0dd5 to
522587f
Compare
lgarber-akamai
force-pushed
the
new/vpc-dual-stack
branch
from
522587f to
d7ddd4a
Compare
lgarber-akamai
requested review from
zliang-akamai and
ykim-akamai
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request implements support for endpoints and request/response fields relating to Dual Stack (IPv6) VPCs. Because the API changes for this feature aren't yet available this PR was developed against unit test mocks.
Changes include:
put_classJSONObject ClassVar that allows PUT requests to use a distinct schema from the schema defined usingjson_objectipv6field under instance config interfaces (both nested and CRUD)ipv6field on VPCs and VPC subnetsipv6_range,ipv6_is_public, andipv6_addressesfields under the VPC IPs endpoints✔️ How to Test
The following test steps assume you have pulled down this PR locally and run
make install.Unit Testing
Integration Testing
Not yet available.
Manual Testing
Not yet available.