Skip to content

Maintenance Policy integration test #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: proj/maintenance-policy
Choose a base branch
from

Conversation

vshanthe
Copy link

@vshanthe vshanthe commented Jul 22, 2025

📝 Description

Add Integration test to Maintenance Policy
Test Against Devcloud - api.devcloud.linode.com

✔️ How to Test

make TEST_SUITE="account" test-int
make test-int TEST_CASE=test_create_linode_maintenance_policy
make test-int TEST_CASE=test_update_linode_maintenance_policy

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@vshanthe vshanthe requested a review from a team as a code owner July 22, 2025 10:34
@vshanthe vshanthe requested review from PawelSnoch, yec-akamai, ezilber-akamai, a team, jriddle-linode and lgarber-akamai and removed request for a team, yec-akamai and jriddle-linode July 22, 2025 10:34
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing locally against DevCloud (other than the account tests, but that is expected). Overall looks good, just one small change :)

@@ -132,3 +151,17 @@ def test_get_payments(test_linode_client):
if len(payments) > 0:
assert isinstance(payments[0].date, datetime)
assert isinstance(payments[0].usd, float)


def test_get_maintenance_policies(test_linode_client):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should probably be in its own file test_maintenance.py since it is not a part of the Account group.

@lgarber-akamai lgarber-akamai removed the request for review from PawelSnoch July 24, 2025 15:37
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than Erik's feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants