-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.0.0 #684
Merged
Merged
v5.0.0 #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in the EOL parser where it would only recognise escaped newline characters, and not actual newlines. This issue was caused by a faulty testing methodology.
Codecov Report
@@ Coverage Diff @@
## master #684 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 5 +1
Lines 58 67 +9
Branches 16 19 +3
=========================================
+ Hits 58 67 +9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version brings with it several new major features to react-console-emulator.
Breaking changes
The recommended method for terminal input text styling has been moved. Terminal input text should now be styled using the
inputTextStyle
andinputTextClassName
props. Note: If using the newly-introduced styling persistence options for command echoes, leaving text styling ininputStyle
orinputClassName
may cause unexpected styling bugs.The
styleEchoBack
prop no longer accepts boolean input. Instead, one should either omit it (For default behaviour) or define one of the string types detailed in the options.Main changes
Async command executor support is here! You can now use async functions as command handlers and their outputs will function identically to synchronous functions.
Added the ability to hide the prompt area entirely when the terminal is disabled either manually through the
disabled
prop or on process ifdisableOnProcess
is enabled (#639).Added the ability to set the terminal to read-only mode with the
readOnly
prop, which disables input entirely and hides the prompt area (#639).Other changes
Fixed a bug where newline parsing did not recognise newline literals properly (#632).
Full run-down of prop changes:
Closes #632
Closes #638
Closes #639
Closes #640